GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/5937

    [FLINK-9270] Upgrade RocksDB to 5.11.3, and resolve concurrent test 
invocation problem of @RetryOnFailure

    ## What is the purpose of the change
    
    - Upgrade RocksDB to 5.11.3 to take latest bug fixes
    - Besides, I found that unit tests annotated with `@RetryOnFailure` will be 
run concurrently if there's only `try` clause without a `catch` following. For 
example, sometimes, `RocksDBPerformanceTest.testRocksDbMergePerformance()` will 
actually be running in 3 concurrent invocations, and multiple concurrent write 
to RocksDB result in errors. 
    
    ## Brief change log
    
    - Upgrade RocksDB to 5.11.3
    - For all RocksDB performance tests, add a `catch` clause to follow `try`
    
    This change is already covered by existing tests
    
    ## Does this pull request potentially affect one of the following parts:
    
    none
    
    ## Documentation
    
    none

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-9270

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5937.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5937
    
----
commit 9fed7b9cba78dfdc6512818d9c2c07fc80892d72
Author: Bowen Li <bowenli86@...>
Date:   2018-04-28T08:32:09Z

    [FLINK-9270] Upgrade RocksDB to 5.11.3, and resolve concurrent test 
invocation problem of @RetryOnFailure

----


---

Reply via email to