[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449989#comment-16449989 ]
ASF GitHub Bot commented on FLINK-9138: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5860#discussion_r183758663 --- Diff: flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java --- @@ -436,6 +463,40 @@ public void testScalingUp() throws Exception { checkFs(outDir, 0, 3, 5, 5); } + @Test + public void testRolloverInterval() throws Exception { + final File outDir = tempFolder.newFolder(); + + OneInputStreamOperatorTestHarness<String, Object> testHarness = createRescalingTestSinkWithRollover(outDir, 1, 0, 1000L, 100L); + testHarness.setup(); + testHarness.open(); + + testHarness.setProcessingTime(0L); + + testHarness.processElement(new StreamRecord<>("test1", 1L)); + checkFs(outDir, 1, 0, 0, 0); --- End diff -- check other `checkFs()` calls as well > Enhance BucketingSink to also flush data by time interval > --------------------------------------------------------- > > Key: FLINK-9138 > URL: https://issues.apache.org/jira/browse/FLINK-9138 > Project: Flink > Issue Type: Improvement > Components: filesystem-connector > Affects Versions: 1.4.2 > Reporter: Narayanan Arunachalam > Priority: Major > > BucketingSink now supports flushing data to the file system by size limit and > by period of inactivity. It will be useful to also flush data by a specified > time period. This way, the data will be written out when write throughput is > low but there is no significant time period gaps between the writes. This > reduces ETA for the data in the file system and should help move the > checkpoints faster as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)