Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5860#discussion_r183756583
  
    --- Diff: 
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
 ---
    @@ -536,6 +553,9 @@ private void openNewPartFile(Path bucketPath, 
BucketState<T> bucketState) throws
                        partPath = new Path(bucketPath, partPrefix + "-" + 
subtaskIndex + "-" + bucketState.partCounter);
                }
     
    +           // Record the creation time of the bucket
    +           bucketState.firstWrittenToTime = 
processingTimeService.getCurrentProcessingTime();
    --- End diff --
    
    rename parameter to `bucket.creationTime`? At this point, nothing has been 
written to the file. Actually, the file has not even been created yet.


---

Reply via email to