[ 
https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449724#comment-16449724
 ] 

ASF GitHub Bot commented on FLINK-9194:
---------------------------------------

Github user yuqi1129 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5902#discussion_r183697720
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobVertexTaskManagersHandler.java
 ---
    @@ -83,6 +90,24 @@ protected JobVertexTaskManagersInfo handleRequest(
                        throw new NotFoundException(String.format("JobVertex %s 
not found", jobVertexID));
                }
     
    +           return createJobVertexTaskManagersInfo(jobVertex, jobID, 
metricFetcher);
    +   }
    +
    +   @Override
    +   public Collection<ArchivedJson> 
archiveJsonWithPath(AccessExecutionGraph graph) throws IOException {
    +           Collection<? extends AccessExecutionJobVertex> vertices = 
graph.getAllVertices().values();
    +           List<ArchivedJson> archive = new ArrayList<>(vertices.size());
    +           for (AccessExecutionJobVertex task : vertices) {
    +                   ResponseBody json = 
createJobVertexTaskManagersInfo(task, graph.getJobID(), null);
    +                   String path = 
getMessageHeaders().getTargetRestEndpointURL()
    +                           .replace(':' + JobIDPathParameter.KEY, 
graph.getJobID().toString())
    --- End diff --
    
    ```
    ':' + JobIDPathParameter.KEY
    ':' + JobVertexIdPathParameter.KEY
    
    ```
    We can make them constant values


> Finished jobs are not archived to HistoryServer
> -----------------------------------------------
>
>                 Key: FLINK-9194
>                 URL: https://issues.apache.org/jira/browse/FLINK-9194
>             Project: Flink
>          Issue Type: Bug
>          Components: History Server, JobManager
>    Affects Versions: 1.5.0
>         Environment: Flink 2af481a
>            Reporter: Gary Yao
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>              Labels: flip-6
>             Fix For: 1.6.0
>
>
> In flip6 mode, jobs are not archived to the HistoryServer. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to