[
https://issues.apache.org/jira/browse/FLINK-9212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16447987#comment-16447987
]
ASF GitHub Bot commented on FLINK-9212:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5893#discussion_r183359424
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtasksAllAccumulatorsInfo.java
---
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.job;
+
+import
org.apache.flink.runtime.rest.handler.job.SubtasksAllAccumulatorsHandler;
+import org.apache.flink.runtime.rest.messages.ResponseBody;
+import org.apache.flink.util.Preconditions;
+
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
+import java.util.Collection;
+import java.util.Objects;
+
+
+/**
+ * Response type of the {@link SubtasksAllAccumulatorsHandler}.
+ */
+public class SubtasksAllAccumulatorsInfo implements ResponseBody {
+
+ public static final String FIELD_NAME_ID = "id";
+ public static final String FIELD_NAME_PARALLELISM = "parallelism";
+ public static final String FILED_NMAE_SUBTASKS = "subtasks";
+
+ @JsonProperty(FIELD_NAME_ID)
+ private String id;
--- End diff --
this should be a `JobVertexID`, and a more descriptive field name would be
great. (the JSON field name should remain the same ;) )
> Port SubtasksAllAccumulatorsHandler to new REST endpoint
> --------------------------------------------------------
>
> Key: FLINK-9212
> URL: https://issues.apache.org/jira/browse/FLINK-9212
> Project: Flink
> Issue Type: Sub-task
> Components: REST
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Hai Zhou
> Priority: Blocker
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
