[GitHub] flink pull request #5888: [FLINK-9194] [histroyserver] Finished jobs are not...

[zentol]

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5888#discussion_r183357018
  
    --- Diff: 
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/history/HistoryServerTest.java
 ---
    @@ -96,9 +108,26 @@ public void testFullArchiveLifecycle() throws Exception 
{
                        String response = getFromHTTP(baseUrl + 
JobsOverviewHeaders.URL);
                        JsonNode overview = mapper.readTree(response);
     
    -                   String jobID = 
overview.get("jobs").get(0).get("jid").asText();
    -                   JsonNode jobDetails = 
mapper.readTree(getFromHTTP(baseUrl + "/jobs/" + jobID));
    -                   Assert.assertNotNull(jobDetails.get("jid"));
    +                   JsonNode allJobs = overview.get("jobs");
    --- End diff --
    
    safer implementation is now possible by reading this as a 
`MultipleJobsDetails`.


---