[ https://issues.apache.org/jira/browse/FLINK-6924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440971#comment-16440971 ]
ASF GitHub Bot commented on FLINK-6924: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5638#discussion_r182104673 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala --- @@ -1130,4 +1130,13 @@ object concat_ws { } } +object log { + def apply(base: Expression, antilogarithm: Expression): Expression = { + Log(base, antilogarithm) + } + def apply(antilogarithm: Expression): Expression = { + new Log(antilogarithm) --- End diff -- We should go for `antilog.log(base)` for consistency with `antilog.ln()` and `antilog.log10()`. Since we need to inverse the parameters of the case class, we need to adapt the `ExpressionParser`. > ADD LOG(X) supported in TableAPI > -------------------------------- > > Key: FLINK-6924 > URL: https://issues.apache.org/jira/browse/FLINK-6924 > Project: Flink > Issue Type: Sub-task > Components: Table API & SQL > Affects Versions: 1.4.0 > Reporter: sunjincheng > Assignee: buptljy > Priority: Major > Labels: starter > > See FLINK-6891 for detail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)