[ 
https://issues.apache.org/jira/browse/FLINK-8955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439536#comment-16439536
 ] 

ASF GitHub Bot commented on FLINK-8955:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5780#discussion_r181759432
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java
 ---
    @@ -202,15 +204,27 @@ public void 
testCheckpointedStreamingClassloaderJobWithCustomClassLoader() throw
                        Collections.singleton(new 
Path(STREAMING_CHECKPOINTED_PROG_JAR_FILE)),
                        Collections.<URL>emptyList());
     
    -           // Program should terminate with a 'SuccessException':
    -           // we can not access the SuccessException here when executing 
the tests with maven, because its not available in the jar.
    -           expectedException.expectCause(
    -                   Matchers.<Throwable>hasProperty("cause",
    -                           hasProperty("class",
    -                                   hasProperty("canonicalName", equalTo(
    -                                           
"org.apache.flink.test.classloading.jar.CheckpointedStreamingProgram.SuccessException")))));
    -
    -           streamingCheckpointedProg.invokeInteractiveModeForExecution();
    +           try {
    --- End diff --
    
    my guess is that the exception stack has changed. The SuccessException is 
no longer the direct cause of the top-level exception.
    
    ```
    Expected: exception with cause hasProperty("cause", hasProperty("class", 
hasProperty("canonicalName", 
"org.apache.flink.test.classloading.jar.CheckpointedStreamingProgram.SuccessException")))
         but: cause property 'cause' property 'class' null
    Stacktrace was: org.apache.flink.client.program.ProgramInvocationException: 
The main method caused an error.
            at 
org.apache.flink.client.program.PackagedProgram.callMainMethod(PackagedProgram.java:545)
            at 
org.apache.flink.client.program.PackagedProgram.invokeInteractiveModeForExecution(PackagedProgram.java:420)
            at 
org.apache.flink.test.classloading.ClassLoaderITCase.testCheckpointedStreamingClassloaderJobWithCustomClassLoader(ClassLoaderITCase.java:212)
            at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
            at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
            at java.lang.reflect.Method.invoke(Method.java:498)
            at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
            at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
            at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
            at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
            at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
            at 
org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:239)
            at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
            at org.junit.rules.RunRules.evaluate(RunRules.java:20)
            at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
            at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
            at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
            at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
            at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
            at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
            at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
            at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
            at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
            at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
            at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
            at org.junit.runners.Suite.runChild(Suite.java:128)
            at org.junit.runners.Suite.runChild(Suite.java:27)
            at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
            at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
            at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
            at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
            at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
            at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
            at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
            at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
            at 
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:108)
            at 
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:78)
            at 
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:54)
            at 
org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:144)
            at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
            at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
            at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
    Caused by: org.apache.flink.runtime.client.JobExecutionException: 
org.apache.flink.test.classloading.jar.CheckpointedStreamingProgram$SuccessException
            at 
org.apache.flink.runtime.minicluster.MiniCluster.executeJobBlocking(MiniCluster.java:621)
            at 
org.apache.flink.streaming.util.TestStreamEnvironment.execute(TestStreamEnvironment.java:79)
            at 
org.apache.flink.test.classloading.jar.CheckpointedStreamingProgram.main(CheckpointedStreamingProgram.java:53)
            at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
            at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
            at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
            at java.lang.reflect.Method.invoke(Method.java:498)
            at 
org.apache.flink.client.program.PackagedProgram.callMainMethod(PackagedProgram.java:528)
            ... 42 more
    Caused by: 
org.apache.flink.test.classloading.jar.CheckpointedStreamingProgram$SuccessException
            at 
org.apache.flink.test.classloading.jar.CheckpointedStreamingProgram$StatefulMapper.map(CheckpointedStreamingProgram.java:116)
            at 
org.apache.flink.test.classloading.jar.CheckpointedStreamingProgram$StatefulMapper.map(CheckpointedStreamingProgram.java:84)
            at 
org.apache.flink.streaming.api.operators.StreamMap.processElement(StreamMap.java:41)
            at 
org.apache.flink.streaming.runtime.io.StreamInputProcessor.processInput(StreamInputProcessor.java:202)
            at 
org.apache.flink.streaming.runtime.tasks.OneInputStreamTask.run(OneInputStreamTask.java:103)
            at 
org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:307)
            at org.apache.flink.runtime.taskmanager.Task.run(Task.java:702)
            at java.lang.Thread.run(Thread.java:745)
    ```


> Port ClassLoaderITCase to flip6
> -------------------------------
>
>                 Key: FLINK-8955
>                 URL: https://issues.apache.org/jira/browse/FLINK-8955
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to