[
https://issues.apache.org/jira/browse/FLINK-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429897#comment-16429897
]
ASF GitHub Bot commented on FLINK-6571:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5394
I think neither solve the problem.
Variant 2 looks identical to what we have in master.
Variant 1 only allows interrupts after the task was canceled.
According to what @StephanEwen said, if the UDF throws an exception after
the task was canceled the exception will be suppressed and should not lead to a
test failure. Since the test did fail it thus must've been thrown _before_ the
task was cancelled. Given that variant 1 still throws an exception in this case
we aren't solving the stability issue.
> InfiniteSource in SourceStreamOperatorTest should deal with
> InterruptedExceptions
> ---------------------------------------------------------------------------------
>
> Key: FLINK-6571
> URL: https://issues.apache.org/jira/browse/FLINK-6571
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.3.0, 1.4.0, 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Critical
> Labels: test-stability
> Fix For: 1.5.0
>
>
> So this is a new one: i got a failing test
> ({{testNoMaxWatermarkOnAsyncStop}}) due to an uncatched InterruptedException.
> {code}
> [00:28:15] Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
> 0.828 sec <<< FAILURE! - in
> org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest
> [00:28:15]
> testNoMaxWatermarkOnAsyncStop(org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest)
> Time elapsed: 0 sec <<< ERROR!
> [00:28:15] java.lang.InterruptedException: sleep interrupted
> [00:28:15] at java.lang.Thread.sleep(Native Method)
> [00:28:15] at
> org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest$InfiniteSource.run(StreamSourceOperatorTest.java:343)
> [00:28:15] at
> org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:87)
> [00:28:15] at
> org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest.testNoMaxWatermarkOnAsyncStop(StreamSourceOperatorTest.java:176)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
