[ 
https://issues.apache.org/jira/browse/FLINK-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429385#comment-16429385
 ] 

ASF GitHub Bot commented on FLINK-9040:
---------------------------------------

GitHub user sihuazhou opened a pull request:

    https://github.com/apache/flink/pull/5825

    [FLINK-9040][local runtime] check maxParallelism in 
JobVertex#setMaxParallelism()

    ## What is the purpose of the change
    
    this PR performs `maxParallelism` checking in 
`JobVertex#setMaxParallelism()`.
    
    ## Brief change log
    
      - check `maxParallelism` in `JobVertex#setMaxParallelism()`
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sihuazhou/flink checkMaxParallelism

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5825.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5825
    
----
commit 20fbb4aecfb5ff5a40b8be23588eae92fbd2b57a
Author: sihuazhou <summerleafs@...>
Date:   2018-04-07T14:12:37Z

    check maxParallelism in JobVertex#setMaxParallelism().

----


> JobVertex#setMaxParallelism does not validate argument
> ------------------------------------------------------
>
>                 Key: FLINK-9040
>                 URL: https://issues.apache.org/jira/browse/FLINK-9040
>             Project: Flink
>          Issue Type: Bug
>          Components: Local Runtime
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Priority: Minor
>
> {code}
> /**
> * Sets the maximum parallelism for the task.
> *
> * @param maxParallelism The maximum parallelism to be set. must be between 1 
> and Short.MAX_VALUE.
> */
> public void setMaxParallelism(int maxParallelism) {
>       this.maxParallelism = maxParallelism;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to