Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5808#discussion_r179045805
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
    @@ -299,15 +299,15 @@
        /**
         * Flag indicating whether to start a thread, which repeatedly logs the 
memory usage of the JVM.
         *
    -    * @deprecated use {@link 
TaskManagerOptions#DEBUG_MEMORY_USAGE_START_LOG_THREAD} instead
    +    * @deprecated use {@link TaskManagerOptions#DEBUG_MEMORY_LOG} instead
         */
        @Deprecated
    -   public static final String 
TASK_MANAGER_DEBUG_MEMORY_USAGE_START_LOG_THREAD = 
"taskmanager.debug.memory.startLogThread";
    +   public static final String TASK_MANAGER_DEBUG_MEMORY_LOG = 
"taskmanager.debug.memory.log";
     
        /**
         * The interval (in ms) for the log thread to log the current memory 
usage.
         *
    -    * @deprecated use {@link 
TaskManagerOptions#DEBUG_MEMORY_USAGE_LOG_INTERVAL_MS} instead
    --- End diff --
    
    I would revert the renaming; it' a useful piece of info that we're dealing 
with milliseconds.


---

Reply via email to