[ 
https://issues.apache.org/jira/browse/FLINK-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424831#comment-16424831
 ] 

ASF GitHub Bot commented on FLINK-9127:
---------------------------------------

GitHub user skidder opened a pull request:

    https://github.com/apache/flink/pull/5810

    [FLINK-9127] [Core] Filesystem State Backend logged incorrectly

    ## What is the purpose of the change
    
    This pull-request fixes a message logged when during startup of the Flink 
Task-Manager and Job-Manager when a filesystem backend is in use.
    
    The old incorrect behavior produced a log message indicating that a 
heap-memory backend is use in.
    
    ## Brief change log
    
      - Fix the log message produced by the StateBackendLoader class in Core.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/skidder/flink FLINK-9127

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5810.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5810
    
----
commit 9e3774bb2a0ceedacde584a47aa9146bcbf47a3a
Author: Scott Kidder <scott@...>
Date:   2018-04-04T01:03:46Z

    [FLINK-9127] Fix log message for filesystem backend

----


> Filesystem State Backend logged incorrectly
> -------------------------------------------
>
>                 Key: FLINK-9127
>                 URL: https://issues.apache.org/jira/browse/FLINK-9127
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.3.2, 1.4.2
>            Reporter: Scott Kidder
>            Priority: Trivial
>
> When using a filesystem backend, the 
> '[StateBackendLoader|https://github.com/apache/flink/blob/1f9c2d9740ffea2b59b8f5f3da287a0dc890ddbf/flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoader.java#L123]'
>  class produces a log message stating: "State backend is set to heap memory". 
> Example:
> {{2018-04-04 00:45:49,591 INFO  
> org.apache.flink.streaming.runtime.tasks.StreamTask           - State backend 
> is set to heap memory (checkpoints to filesystem 
> "hdfs://hdfs:8020/flink/checkpoints")}}
> It looks like this resulted from some copy-pasta of the previous 
> case-statement that matches on the memory backend. This bug is also present 
> in earlier releases (1.3.2, 1.4.0) of Flink in the 'AbstractStateBackend' 
> class.
> This log statement should be corrected to indicate that a filesystem backend 
> is in use.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to