[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424030#comment-16424030
]
ASF GitHub Bot commented on FLINK-8835:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5808
[FLINK-8835] [taskmanager] Fix TaskManager config keys
## What is the purpose of the change
Fix TaskManager config keys to make it easier for users.
## Brief change log
Change the original key and variable name to a easier way.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink
flink-8835-taskmanager-config-key
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5808.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5808
----
commit a4df41079edd228ea346227f2f04b41d694c0420
Author: zhangminglei <zml13856086071@...>
Date: 2018-04-03T13:23:19Z
[FLINK-8835] [taskmanager] Fix TaskManager config keys
----
> Fix TaskManager config keys
> ---------------------------
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
> Reporter: Stephan Ewen
> Assignee: mingleizhang
> Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
