[
https://issues.apache.org/jira/browse/FLINK-8966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423942#comment-16423942
]
ASF GitHub Bot commented on FLINK-8966:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5766#discussion_r178805958
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
---
@@ -651,6 +659,34 @@ private DispatcherGateway getDispatcherGateway()
throws LeaderRetrievalException
}
}
+ private void uploadJarFiles(final DispatcherGateway
currentDispatcherGateway, final JobGraph job) throws JobExecutionException,
InterruptedException {
--- End diff --
Could we pass in the `JobID` and the collection of user jars instead of the
`JobGraph`? We would then not set the blob keys in this function but instead
return them. That way we would make this method only do the upload instead of
multiple things. I think this would better follow the single responsibility
principle.
> Port AvroExternalJarProgramITCase to flip6
> ------------------------------------------
>
> Key: FLINK-8966
> URL: https://issues.apache.org/jira/browse/FLINK-8966
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.5.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
