[
https://issues.apache.org/jira/browse/FLINK-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415144#comment-16415144
]
ASF GitHub Bot commented on FLINK-9094:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5771
[FLINK-9094] [tests] Harden AccumulatorLiveITCase
## What is the purpose of the change
The problem was that we did not wait for the proper shut down of the job
before
resetting the latches. This could lead to a deadlock.
cc @zentol
## Brief change log
- Introduce `NewClusterClient` interface
- Wait in `AccumulatorLiveITCase` for job termination
## Verifying this change
- Covered by existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink hardenAccumulatorLiveITCase
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5771.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5771
----
commit 61f59dff0c8b5862af302d7d4a0acea360d6aa34
Author: Till Rohrmann <trohrmann@...>
Date: 2018-03-27T07:20:33Z
[hotfix] Introduce NewClusterClient interface
The NewClusterClient interface contains asynchronous submitJob and
requestJobResult
methods which will replace the ClusterClient#submitJob method.
commit 5c0a3f12dbe0dfa81e4b6164a95a6cf879c6d84d
Author: Till Rohrmann <trohrmann@...>
Date: 2018-03-27T07:22:08Z
[FLINK-9094] [tests] Harden AccumulatorLiveITCase
The problem was that we did not wait for the proper shut down of the job
before
resetting the latches. This could lead to a deadlock.
----
> AccumulatorLiveITCase unstable on Travis
> ----------------------------------------
>
> Key: FLINK-9094
> URL: https://issues.apache.org/jira/browse/FLINK-9094
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Critical
>
> {{AccumulatorLiveITCase}} unstable on Travis.
> https://api.travis-ci.org/v3/job/358509206/log.txt
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
