[ 
https://issues.apache.org/jira/browse/FLINK-9059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413686#comment-16413686
 ] 

Timo Walther commented on FLINK-9059:
-------------------------------------

Thanks for working on this [~suez1224]. Just a minor thing that I mentioned in 
some other document to be consistent for the "tableType" property:

_Please try to reuse key names as much as possible. Key-names should be 
hierarchical and lower case. Use "-" instead of dots or camel case. E.g., 
connector.schema.start-from = from-earliest. Try not to use the higher level in 
a key-name. E.g., instead of connector.kafka.kafka-version use 
connector.kafka.version._

So maybe we should name it either just {{type}} or {{table-type}}.

> Add support for unified table source and sink declaration in environment file
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-9059
>                 URL: https://issues.apache.org/jira/browse/FLINK-9059
>             Project: Flink
>          Issue Type: Task
>          Components: Table API & SQL
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>            Priority: Major
>             Fix For: 1.5.0
>
>
> 1) Add a common property called "tableType" with single value 'source'.
> 2) in yaml file, replace "sources" with "tables".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to