GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5763

    [hotfix][tests] Hide output from config.sh

    ## What is the purpose of the change
    
    The `TaskManagerHeapSizeCalculationJavaBashTest` calls the 
`calcTMHeapSizeMB.sh/calcTMNetBufMem.sh` scripts and expects the result to be 
printed to stdout. These scripts also all `config.sh` which may `echo` messages 
that would result in a test failure, like the one below on AWS.
    
    ```
    
compareHeapSizeShellScriptWithJava(org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest)
  Time elapsed: 0.486 sec  <<< FAILURE!
    org.junit.ComparisonFailure: Different heap sizes with configuration: 
{taskmanager.network.memory.fraction=0.1, taskmanager.memory.off-heap=false, 
taskmanager.memory.fraction=0.7, taskmanager.memory.size=-1, 
taskmanager.network.memory.max=1073741824, taskmanager.heap.mb=1000, 
taskmanager.network.memory.min=67108864} expected:<[]900> but was:<[Setting 
HADOOP_CONF_DIR=/etc/hadoop/conf because no HADOOP_CONF_DIR was set.]900>
            at org.junit.Assert.assertEquals(Assert.java:115)
            at 
org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest.compareHeapSizeJavaVsScript(TaskManagerHeapSizeCalculationJavaBashTest.java:275)
            at 
org.apache.flink.dist.TaskManagerHeapSizeCalculationJavaBashTest.compareHeapSizeShellScriptWithJava(TaskManagerHeapSizeCalculationJavaBashTest.java:110)
    ```
    
    To prevent this from happening this PR suppresses the standard output from 
`config.sh`.
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink calc_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5763.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5763
    
----

----


---

Reply via email to