Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5624#discussion_r176492623
  
    --- Diff: 
flink-filesystems/flink-s3-fs-presto/src/test/java/org/apache/flink/fs/s3presto/PrestoS3FileSystemITCase.java
 ---
    @@ -143,7 +157,20 @@ public void testDirectoryListing() throws Exception {
                        fs.delete(directory, true);
                }
     
    -           // now directory must be gone
    -           assertFalse(fs.exists(directory));
    +           // now directory must be gone (this is eventually-consistent, 
though!)
    +           checkPathExists(fs, directory, false, deadline);
    +   }
    +
    +   private static void checkPathExists(
    --- End diff --
    
    makes sense - I created `org.apache.flink.core.fs.FileSystemTestUtils` for 
this helper method


---

Reply via email to