[
https://issues.apache.org/jira/browse/FLINK-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408528#comment-16408528
]
ASF GitHub Bot commented on FLINK-9027:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5740
[FLINK-9027] [web] Clean up web UI resources by installing shut down hook
## What is the purpose of the change
The RestServerEndpoint creates temp directories to upload files and store
the web ui.
In case of a hard shut down, as it happens with bin/stop-cluster.sh we
should still
delete these files. We do this by installing a shut down hook.
## Verifying this change
- Manually tested
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink cleanupWebUI
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5740.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5740
----
commit 719abe3766f406e5b0cac4afc3597a084061769c
Author: Till Rohrmann <trohrmann@...>
Date: 2018-03-21T20:04:40Z
[FLINK-9027] [web] Clean up web UI resources by installing shut down hook
The RestServerEndpoint creates temp directories to upload files and store
the web ui.
In case of a hard shut down, as it happens with bin/stop-cluster.sh we
should still
delete these files. We do this by installing a shut down hook.
commit 659479f6d67b97bf63b66df57eeaf5c11195af73
Author: Till Rohrmann <trohrmann@...>
Date: 2018-03-21T20:08:13Z
[hotfix] Make RestServerEndpoint#uploadDir protected
----
> Web UI does not cleanup temporary files
> ---------------------------------------
>
> Key: FLINK-9027
> URL: https://issues.apache.org/jira/browse/FLINK-9027
> Project: Flink
> Issue Type: Bug
> Components: Webfrontend
> Affects Versions: 1.5.0
> Reporter: Nico Kruber
> Assignee: Till Rohrmann
> Priority: Blocker
> Fix For: 1.5.0
>
>
> The web UI creates two directories in {{java.io.tmp}}, namely
> {{flink-web-<uuid>}} and {{flink-web-upload-<uuid>}} and both are not cleaned
> up (running {{start-cluster.sh}} and {{stop-cluster.sh}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
