[
https://issues.apache.org/jira/browse/FLINK-8721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407950#comment-16407950
]
ASF GitHub Bot commented on FLINK-8721:
---------------------------------------
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/5737
[FLINK-8721][flip6] Handle archiving failures for accumulators
During archivization, wrap errors thrown by users' Accumulators into a
FailedAccumulator and do not fail the job because of that.
## Verifying this change
This change is covered by existing AccumulatorErrorITCase
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pnowojski/flink f8721
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5737.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5737
----
commit c61014ae458767926c4f5b13a9df7bc70135d13c
Author: Piotr Nowojski <piotr.nowojski@...>
Date: 2018-03-21T09:54:49Z
[hotfix][runtime] Remove unused method
commit 655644322f7c61ddd89bcc3e5aab636047b97d55
Author: Piotr Nowojski <piotr.nowojski@...>
Date: 2018-03-21T12:08:36Z
[FLINK-8721][flip6] Handle archiving failures for accumulators
----
> Client blocks indefinitely if job archiving fails
> -------------------------------------------------
>
> Key: FLINK-8721
> URL: https://issues.apache.org/jira/browse/FLINK-8721
> Project: Flink
> Issue Type: Improvement
> Components: Client, JobManager
> Affects Versions: 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Piotr Nowojski
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0
>
>
> While porting the {{AccumulatorErrorITCase}} i noticed that, for FLIP-6, if
> the job archiving fails (in this case due to a custom accumulator throwing an
> exception in #merge) no response is sent to the client.
> {code}
> 3547 [flink-akka.actor.default-dispatcher-2] ERROR
> org.apache.flink.runtime.rpc.akka.FencedAkkaRpcActor - Caught exception
> while executing runnable in main thread.
> org.apache.flink.test.accumulators.AccumulatorErrorITCase$CustomException
> at
> org.apache.flink.test.accumulators.AccumulatorErrorITCase$FaultyAccumulator.clone(AccumulatorErrorITCase.java:113)
> at
> org.apache.flink.test.accumulators.AccumulatorErrorITCase$FaultyAccumulator.clone(AccumulatorErrorITCase.java:107)
> at
> org.apache.flink.api.common.accumulators.AccumulatorHelper.mergeInto(AccumulatorHelper.java:52)
> at
> org.apache.flink.runtime.executiongraph.ExecutionJobVertex.getAggregatedUserAccumulatorsStringified(ExecutionJobVertex.java:599)
> at
> org.apache.flink.runtime.executiongraph.ArchivedExecutionJobVertex.<init>(ArchivedExecutionJobVertex.java:49)
> at
> org.apache.flink.runtime.executiongraph.ExecutionJobVertex.archive(ExecutionJobVertex.java:612)
> at
> org.apache.flink.runtime.executiongraph.ArchivedExecutionGraph.createFrom(ArchivedExecutionGraph.java:313)
> at
> org.apache.flink.runtime.jobmaster.JobMaster.jobStatusChanged(JobMaster.java:985)
> at
> org.apache.flink.runtime.jobmaster.JobMaster.access$1400(JobMaster.java:136)
> at
> org.apache.flink.runtime.jobmaster.JobMaster$JobManagerJobStatusListener.lambda$jobStatusChanges$0(JobMaster.java:1181)
> at
> org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleRunAsync(AkkaRpcActor.java:292)
> at
> org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleMessage(AkkaRpcActor.java:147)
> at
> org.apache.flink.runtime.rpc.akka.FencedAkkaRpcActor.handleMessage(FencedAkkaRpcActor.java:66)
> at
> org.apache.flink.runtime.rpc.akka.AkkaRpcActor.lambda$onReceive$0(AkkaRpcActor.java:129)
> at
> akka.actor.ActorCell$$anonfun$become$1.applyOrElse(ActorCell.scala:544)
> at akka.actor.Actor$class.aroundReceive(Actor.scala:502)
> at akka.actor.UntypedActor.aroundReceive(UntypedActor.scala:95)
> at akka.actor.ActorCell.receiveMessage(ActorCell.scala:526)
> at akka.actor.ActorCell.invoke(ActorCell.scala:495)
> at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257)
> at akka.dispatch.Mailbox.run(Mailbox.scala:224)
> at akka.dispatch.Mailbox.exec(Mailbox.scala:234)
> at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
> at
> scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
> at
> scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
> at
> scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
