[ 
https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406174#comment-16406174
 ] 

ASF GitHub Bot commented on FLINK-8703:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5701#discussion_r175731028
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java
 ---
    @@ -87,17 +89,24 @@ protected static String getResourceFilename(String 
filename) {
                return resource.getFile();
        }
     
    -   @Before
    -   public void setup() throws Exception {
    +   private Configuration getConfigurationSafe() {
    --- End diff --
    
    I think we can get rid of this method by moving the `miniClusterResource` 
initialization to the constructor which says that it can throw an `Exception`.


> Migrate tests from LocalFlinkMiniCluster to MiniClusterResource
> ---------------------------------------------------------------
>
>                 Key: FLINK-8703
>                 URL: https://issues.apache.org/jira/browse/FLINK-8703
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Aljoscha Krettek
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to