[
https://issues.apache.org/jira/browse/FLINK-8843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401804#comment-16401804
]
ASF GitHub Bot commented on FLINK-8843:
---------------------------------------
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5707
[FLINK-8843][flip6] Decouple bind REST address from advertised address
## What is the purpose of the change
*The `RestServerEndpoint` is currently bound to the same address which is
also advertised to the client, namely `RestOptions#REST_ADDRESS`. It would be
better to start the `RestServerEndpoint` listening on all address by binding to
`0.0.0.0` by default.*
## Brief change log
- *By default bind REST server on wildcard address.*
- *Rename `RestServerEndpoint#getRestAddress` to `getRestBaseUrl`.*
## Verifying this change
This change is already covered by existing tests, such as
`RestServerEndpointITCase.java`.
This change added tests and can be verified as follows:
- *Manually deployed Flink Cluster on YARN & Standalone mode.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/GJL/flink FLINK-8843
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5707.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5707
----
commit 44bacfaba9ddf35f6a74035e3719f34c98513c04
Author: gyao <gary@...>
Date: 2018-03-16T05:57:24Z
[hotfix][flip6] Only create new terminationFuture if MiniCluster is running
commit 5ef0e81d4476ac2ed8a9b3c513cc5a2458d1bf05
Author: gyao <gary@...>
Date: 2018-03-15T21:04:58Z
[FLINK-8843][REST] Decouple bind REST address from advertised address
By default bind REST server on wildcard address.
Rename RestServerEndpoint#getRestAddress to getRestBaseUrl.
----
> Decouple bind REST address from advertised address
> --------------------------------------------------
>
> Key: FLINK-8843
> URL: https://issues.apache.org/jira/browse/FLINK-8843
> Project: Flink
> Issue Type: Improvement
> Components: REST
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Till Rohrmann
> Assignee: Gary Yao
> Priority: Critical
> Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{RestServerEndpoint}} is currently bound to the same address which is
> also advertised to the client, namely {{RestOptions#REST_ADDRESS}}. It would
> be better to start the {{RestServerEndpoint}} listening on all address by
> binding to {{0.0.0.0}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
