[ 
https://issues.apache.org/jira/browse/FLINK-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400126#comment-16400126
 ] 

vinoyang commented on FLINK-8946:
---------------------------------

Hi [~till.rohrmann] , about this issue I think we could :

init the instance of *TaskManagerMetricGroup* in method (if jm failover , we 
could have a new instance):
{code:java}
handleJobManagerLeaderAddress
{code}
and close the metric group in method :
{code:java}
handleJobManagerDisconnect
{code}
at last, we can recheck and close in TaskManager's postStop method.

 

 

 

 

> TaskManager stop sending metrics after JobManager failover
> ----------------------------------------------------------
>
>                 Key: FLINK-8946
>                 URL: https://issues.apache.org/jira/browse/FLINK-8946
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics, TaskManager
>    Affects Versions: 1.4.2
>            Reporter: Truong Duc Kien
>            Assignee: vinoyang
>            Priority: Major
>
> Running in Yarn-standalone mode, when the Job Manager performs a failover, 
> all TaskManager that are inherited from the previous JobManager will not send 
> metrics to the new JobManager and other registered metric reporters.
>  
> A cursory glance reveal that these line of code might be the cause
> [https://github.com/apache/flink/blob/a3478fdfa0f792104123fefbd9bdf01f5029de51/flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala#L1082-L1086]
> Perhap the TaskManager close its metrics group when disassociating 
> JobManager, but not creating a new one on fail-over association ?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to