[ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393051#comment-16393051 ]
ASF GitHub Bot commented on FLINK-8357: --------------------------------------- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5371 Two more questions about this: 1. There is code in the shell scripts that rotates log file each time you start / stop the cluster, with .0 /.1/.2/etc suffixes to the log files. Have you tested whether that still works with the changed setup? 2. I think rolling by time is something that users expect more commonly that rolling by size. What do you think here? > enable rolling in default log settings > -------------------------------------- > > Key: FLINK-8357 > URL: https://issues.apache.org/jira/browse/FLINK-8357 > Project: Flink > Issue Type: Improvement > Components: Logging > Reporter: Xu Mingmin > Assignee: mingleizhang > Priority: Major > Fix For: 1.5.0 > > > The release packages uses {{org.apache.log4j.FileAppender}} for log4j and > {{ch.qos.logback.core.FileAppender}} for logback, which could results in very > large log files. > For most cases, if not all, we need to enable rotation in a production > cluster, and I suppose it's a good idea to make rotation as default. -- This message was sent by Atlassian JIRA (v7.6.3#76005)