[ 
https://issues.apache.org/jira/browse/FLINK-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392953#comment-16392953
 ] 

ASF GitHub Bot commented on FLINK-8822:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5609
  
    ehh...probably. The PR has a point as `sed --help` (v4.2.2) does not list 
the `-E` option.
    
    If we want to be super safe we could check that  `sed -r` is supported and 
use `-E` as a backup.


> RotateLogFile may not work well when sed version is below 4.2
> -------------------------------------------------------------
>
>                 Key: FLINK-8822
>                 URL: https://issues.apache.org/jira/browse/FLINK-8822
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Xin Liu
>            Priority: Major
>             Fix For: 1.5.0
>
>
> In bin/config.sh rotateLogFilesWithPrefix(),it use extended regular to 
> process filename with "sed -E",but when sed version is below 4.2,it turns out 
> "sed: invalid option -- 'E'"
> and RotateLogFile won't work well : There will be only one logfile no matter 
> what is $MAX_LOG_FILE_NUMBER.
> so use sed -r may be more suitable.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to