[
https://issues.apache.org/jira/browse/FLINK-8854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392937#comment-16392937
]
ASF GitHub Bot commented on FLINK-8854:
---------------------------------------
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5662
Thanks for the comments @xccui. It's never to late for feedback. Sorry,
maybe I merged this too quickly. We still need to call
`builder.forJsonSchema()` if the schema contains a `proctime` attribute. The
most common use case will be to extend the format by time attributes. With your
approach the format would contain an additional timestamp that is definitely
not part of the format schema.
> Mapping of SchemaValidator.deriveFieldMapping() is incorrect.
> -------------------------------------------------------------
>
> Key: FLINK-8854
> URL: https://issues.apache.org/jira/browse/FLINK-8854
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.5.0
> Reporter: Fabian Hueske
> Assignee: Timo Walther
> Priority: Blocker
> Fix For: 1.5.0, 1.6.0
>
>
> The field mapping returned by {{SchemaValidator.deriveFieldMapping()}} is not
> correct.
> It should not only include all fields of the table schema, but also all
> fields of the format schema (mapped to themselves). Otherwise, it is not
> possible to use a timestamp extractor on a field that is not in table schema.
> For example this configuration would fail:
> {code}
> sources:
> - name: TaxiRides
> schema:
> - name: rideId
> type: LONG
> - name: rowTime
> type: TIMESTAMP
> rowtime:
> timestamps:
> type: "from-field"
> from: "rideTime"
> watermarks:
> type: "periodic-bounded"
> delay: "60000"
> connector:
> ....
> format:
> property-version: 1
> type: json
> schema: "ROW(rideId LONG, rideTime TIMESTAMP)"
> {code}
> because {{rideTime}} is not in the table schema.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
