Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5530
  
    I think this looks quite good now.
    
    Since 1.5 feature freeze is over for a bit, would suggest to merge this 
into master (1.6-SNAPSHOT).
    
    Looking at the code (this PR and the high availability configuration in 
general), I would suggest to work towards the following design in the future:
    
      - We don't have specific high availability enums and setting, everything 
is just an implementation of HAServices. Some HAServices are in fact not highly 
available (maybe we need to find a better name for HAServices).
      - There are factories for all HAServices
      - We simply have "none" and "zookeeper" as aliases for the respective 
factories.
    
    That mirrors the design of he state backends and their configuration, which 
is nice, because we never need to do special checks like 
"isHighAvailabilityEnabled".


---

Reply via email to