Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5617#discussion_r172009559
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -476,14 +379,12 @@ protected Configuration
applyCommandLineOptionsToConfiguration(CommandLine comma
final ApplicationId applicationId = getClusterId(commandLine);
- if (applicationId != null) {
- final String zooKeeperNamespace;
- if (commandLine.hasOption(zookeeperNamespace.getOpt())){
- zooKeeperNamespace =
commandLine.getOptionValue(zookeeperNamespace.getOpt());
- } else {
- zooKeeperNamespace =
effectiveConfiguration.getString(HA_CLUSTER_ID, applicationId.toString());
- }
-
+ final String zooKeeperNamespace;
+ if (commandLine.hasOption(zookeeperNamespace.getOpt())){
+ zooKeeperNamespace =
commandLine.getOptionValue(zookeeperNamespace.getOpt());
--- End diff --
Should have a space after ```if```
---
