Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5449#discussion_r171858504
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/net/ConnectionUtilsTest.java
 ---
    @@ -61,7 +61,7 @@ public void testReturnLocalHostAddressUsingHeuristics() 
throws Exception {
                        assertNotNull(add);
     
                        // make sure that we returned the 
InetAddress.getLocalHost as a heuristic
    -                   assertEquals(InetAddress.getLocalHost(), add);
    +                   assertEquals(InetAddress.getByName("localhost"), add);
    --- End diff --
    
    How about also changing the blocker above to accept connections on any 
interface just to rule accidental successful resolve attempts out, too, i.e. 
using `ServerSocket blocker = new ServerSocket(0, 1, null)`?


---

Reply via email to