[ 
https://issues.apache.org/jira/browse/FLINK-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620638#comment-14620638
 ] 

ASF GitHub Bot commented on FLINK-2329:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/893#discussion_r34264492
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/instance/Instance.java ---
    @@ -43,8 +41,8 @@
        /** The lock on which to synchronize allocations and failure state 
changes */
        private final Object instanceLock = new Object();
     
    -   /** The actor ref to the task manager represented by this taskManager. 
*/
    -   private final ActorRef taskManager;
    +   /** The instacne gateway to communicate with the instance */
    --- End diff --
    
    typo


> Refactor RPCs from within the ExecutionGraph
> --------------------------------------------
>
>                 Key: FLINK-2329
>                 URL: https://issues.apache.org/jira/browse/FLINK-2329
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, TaskManager
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 0.10
>
>
> Currently, we store an {{ActorRef}} of the TaskManager into an {{Instance}} 
> object. This {{ActorRef}} is used from within {{Executions}} to interact with 
> the {{TaskManager}}. This is not a nice abstraction since it does not hide 
> implementation details. 
> Since we need to add a leader session ID to messages sent by the 
> {{Executions}} in order to support high availability, we would need to make 
> the leader session ID available to the {{Execution}}. A better solution seems 
> to be to replace the direct {{ActorRef}} interaction with an instance gateway 
> abstraction which encapsulates the communication logic. Having such an 
> abstraction, it will be easy to decorate messages transparently with a leader 
> session ID. Therefore, I propose to refactor the current {{Instance}} 
> communication and to introduce an {{InstanceGateway}} abstraction.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to