[ https://issues.apache.org/jira/browse/FLINK-8816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381422#comment-16381422 ]
ASF GitHub Bot commented on FLINK-8816: --------------------------------------- Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5604 Hi, @tillrohrmann Could you please have a look at this? > Remove the oldWorker only after starting newWorker successfully in > registerTaskExecutorInternal() > ------------------------------------------------------------------------------------------------- > > Key: FLINK-8816 > URL: https://issues.apache.org/jira/browse/FLINK-8816 > Project: Flink > Issue Type: Bug > Components: Distributed Coordination > Affects Versions: 1.5.0 > Reporter: Sihua Zhou > Assignee: Sihua Zhou > Priority: Major > Fix For: 1.5.0 > > > We should remove the oldWorker only after starting newWorker successfully in > {{ResourceManager#registerTaskExecutorInternal}} and javadoc for > {{SlotProvider#allocateSlot}} is outdated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)