[ 
https://issues.apache.org/jira/browse/FLINK-7805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380708#comment-16380708
 ] 

ASF GitHub Bot commented on FLINK-7805:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5597#discussion_r171323504
  
    --- Diff: 
flink-yarn/src/test/java/org/apache/flink/yarn/RegisterApplicationMasterResponseReflectorTest.java
 ---
    @@ -0,0 +1,115 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.yarn;
    +
    +import org.apache.hadoop.util.VersionInfo;
    +import 
org.apache.hadoop.yarn.api.protocolrecords.RegisterApplicationMasterResponse;
    +import org.apache.hadoop.yarn.api.records.Container;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.mockito.Mock;
    +import org.mockito.MockitoAnnotations;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.lang.reflect.Method;
    +import java.util.Arrays;
    +import java.util.Collections;
    +import java.util.List;
    +
    +import static org.hamcrest.Matchers.empty;
    +import static org.hamcrest.Matchers.hasSize;
    +import static org.hamcrest.Matchers.notNullValue;
    +import static org.junit.Assert.assertThat;
    +import static org.junit.Assume.assumeTrue;
    +
    +/**
    + * Tests for {@link RegisterApplicationMasterResponseReflector}.
    + */
    +public class RegisterApplicationMasterResponseReflectorTest {
    --- End diff --
    
    `TestLogger` missing.


> Add HA capabilities to YarnResourceManager
> ------------------------------------------
>
>                 Key: FLINK-7805
>                 URL: https://issues.apache.org/jira/browse/FLINK-7805
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination, YARN
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Gary Yao
>            Priority: Major
>              Labels: flip-6
>
> The new {{YarnResourceManager}} implementation does not retrieve allocated 
> containers from previous attempts in HA mode like the old 
> {{YarnFlinkResourceManager}} did. We should add this functionality in order 
> to properly support long running Yarn applications [1].
> [1] 
> https://de.hortonworks.com/blog/apache-hadoop-yarn-hdp-2-2-fault-tolerance-features-long-running-services/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to