Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5581#discussion_r171210203
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SubpartitionTestBase.java
 ---
    @@ -182,7 +182,7 @@ private static void assertNextBufferOrEvent(
                        ResultSubpartitionView readView,
                        int expectedReadableBufferSize,
                        boolean expectedIsBuffer,
    -                   Class<? extends AbstractEvent> expectedEventClass,
    +                   @Nullable Class<? extends AbstractEvent> 
expectedEventClass,
    --- End diff --
    
    I added the recycling in case of failures but kept the `@Nullable` because 
otherwise this would need some more duplication with this cleanup


---

Reply via email to