[
https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379063#comment-16379063
]
ASF GitHub Bot commented on FLINK-8689:
---------------------------------------
Github user walterddr commented on the issue:
https://github.com/apache/flink/pull/5555
I agree this design is much cleaner and easier to maintain later. I was
hesitating to change the function signature of `generateAggregations()`.
I will try to introduce some common building blocks and handle
implementation effort in codegen. I will imagine a lot of ITCases will be
needed :-)
Thanks for the feedback @hequn8128 @fhueske
> Add runtime support of distinct filter using MapView
> -----------------------------------------------------
>
> Key: FLINK-8689
> URL: https://issues.apache.org/jira/browse/FLINK-8689
> Project: Flink
> Issue Type: Sub-task
> Reporter: Rong Rong
> Assignee: Rong Rong
> Priority: Major
>
> This ticket should cover distinct aggregate function support to codegen for
> *AggregateCall*, where *isDistinct* fields is set to true.
> This can be verified using the following SQL, which is not currently
> producing correct results.
> {code:java}
> SELECT
> a,
> SUM(b) OVER (PARTITION BY a ORDER BY proctime ROWS BETWEEN 5 PRECEDING AND
> CURRENT ROW)
> FROM
> MyTable{code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
