Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5583#discussion_r170987211
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/UnionInputGate.java
---
@@ -189,11 +189,11 @@ public void requestPartitions() throws IOException,
InterruptedException {
bufferOrEvent.setChannelIndex(channelIndexOffset +
bufferOrEvent.getChannelIndex());
- return Optional.ofNullable(bufferOrEvent);
+ return Optional.of(bufferOrEvent);
}
@Override
- public Optional<BufferOrEvent> pollNextBufferOrEvent() throws
IOException, InterruptedException {
+ public Optional<BufferOrEvent> pollNextBufferOrEvent() throws
UnsupportedOperationException {
--- End diff --
we don't need to - I thought this makes it more explicit if anyone tries to
use this method in an IDE without looking at the code (which is a mistake imho,
but commonly done)
---
