Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5572#discussion_r170590385
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkThroughputBenchmarkTests.java
 ---
    @@ -52,6 +52,14 @@ public void largeRemoteMode() throws Exception {
                env.tearDown();
        }
     
    +   @Test
    +   public void largeRemoteAlwaysFlush() throws Exception {
    +           StreamNetworkThroughputBenchmark env = new 
StreamNetworkThroughputBenchmark();
    +           env.setUp(1, 1, 0, false);
    +           env.executeBenchmark(1_000_000);
    +           env.tearDown();
    +   }
    --- End diff --
    
    Is this not tested via your non-IT tests now?
    (we should be careful about adding integration/full stack tests because of 
their added time)


---

Reply via email to