[ 
https://issues.apache.org/jira/browse/FLINK-8703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371461#comment-16371461
 ] 

ASF GitHub Bot commented on FLINK-8703:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5542#discussion_r169648970
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/BigUserProgramJobSubmitITCase.java
 ---
    @@ -43,40 +40,27 @@
     /**
      * Integration test that verifies that a user program with a big(ger) 
payload is successfully
      * submitted and run.
    + *
    + * <p>This test fails for non-flip6 cluster due to job submission payload 
being too large, see [FLINK-7285].
      */
    -@Ignore("Fails on job submission payload being too large - [FLINK-7285]")
    +@Category(Flip6.class)
     public class BigUserProgramJobSubmitITCase extends TestLogger {
     
        // 
------------------------------------------------------------------------
        //  The mini cluster that is shared across tests
        // 
------------------------------------------------------------------------
     
    -   private static final int DEFAULT_PARALLELISM = 1;
    -
    -   private static LocalFlinkMiniCluster cluster;
    -
    -   private static final Logger LOG = 
LoggerFactory.getLogger(BigUserProgramJobSubmitITCase.class);
    +   @ClassRule
    +   public static final MiniClusterResource MINI_CLUSTER_RESOURCE = new 
MiniClusterResource(
    +           new MiniClusterResource.MiniClusterResourceConfiguration(
    +                   new Configuration(),
    +                   1,
    +                   1));
     
        // 
------------------------------------------------------------------------
        //  Cluster setup & teardown
        // 
------------------------------------------------------------------------
     
    -   @BeforeClass
    -   public static void setup() throws Exception {
    -           // make sure we do not use a singleActorSystem for the tests
    -           // (therefore, we cannot simply inherit from 
StreamingMultipleProgramsTestBase)
    --- End diff --
    
    Doesn't the `MiniClusterResource` always start the cluster with a single 
actor system? I'm wondering why this test succeeds then.


> Migrate tests from LocalFlinkMiniCluster to MiniClusterResource
> ---------------------------------------------------------------
>
>                 Key: FLINK-8703
>                 URL: https://issues.apache.org/jira/browse/FLINK-8703
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>            Reporter: Aljoscha Krettek
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to