[ https://issues.apache.org/jira/browse/FLINK-8700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369852#comment-16369852 ]
mingleizhang commented on FLINK-8700: ------------------------------------- Hi, [~aljoscha] I am not very sure whether we need another method like {{startFlip6Cluster}} in {{TestBaseUtil}} class. And make these method {{startFlip6Cluster}} and {{startCluster}} co-exist. Thanks. > Port tests from FlinkMiniCluster to MiniClusterResource > ------------------------------------------------------- > > Key: FLINK-8700 > URL: https://issues.apache.org/jira/browse/FLINK-8700 > Project: Flink > Issue Type: Improvement > Components: Tests > Reporter: Aljoscha Krettek > Priority: Blocker > Fix For: 1.5.0 > > > Quite some ITCases rely on {{FlinkMiniCluster}} and its subclasses > ({{LocalFlinkMiniCluster}} and {{TestingCluster}}). This means they use the > legacy {{JobManager}} and {{TaskManager}} and not the new FLIP-6 components > which are enabled by default in Flink 1.5.0. > {{AbstractTestBase}} uses the new {{MiniClusterResource}} which encapsulates > creation of a FLIP-6 cluster or legacy cluster. We should use this in all > ITCases, which probably means that we have to extend it a bit, for example to > allow access to a {{ClusterClient}}. > Transitively, {{TestBaseUtils.startCluster()}} also uses the legacy > {{LocalFlinkMiniCluster}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)