[ https://issues.apache.org/jira/browse/FLINK-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369224#comment-16369224 ]
ASF GitHub Bot commented on FLINK-8639: --------------------------------------- Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/5465 About your `AutoCloseable` proposal, I think on the one hand it is nicer for the implementation and on the other hand it is a bit more dangerous for users. If user code forgets to close the iterator, they can potentially not release native resources . > Fix always need to seek multiple times when iterator RocksDBMapState > -------------------------------------------------------------------- > > Key: FLINK-8639 > URL: https://issues.apache.org/jira/browse/FLINK-8639 > Project: Flink > Issue Type: Improvement > Components: State Backends, Checkpointing > Affects Versions: 1.4.0 > Reporter: Sihua Zhou > Assignee: Sihua Zhou > Priority: Critical > Fix For: 1.5.0 > > > Currently, almost every time we want to iterator a RocksDBMapState we need to > do seek at least 2 times (Seek is a poor performance action for rocksdb cause > it can't use the bloomfilter). This is because `RocksDBMapIterator` use a > `cacheEntries` to cache the seek values every time and the `cacheEntries`'s > init size is 1. -- This message was sent by Atlassian JIRA (v7.6.3#76005)