Github user jeis2497052 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5497#discussion_r168853984
  
    --- Diff: docs/dev/migration.md ---
    @@ -145,16 +145,16 @@ public class BufferingSink implements 
SinkFunction<Tuple2<String, Integer>>,
             bufferedElements.add(value);
             if (bufferedElements.size() == threshold) {
                 for (Tuple2<String, Integer> element: bufferedElements) {
    -           // send it to the sink
    -       }
    -       bufferedElements.clear();
    -   }
    +            // send it to the sink
    +        }
    +        bufferedElements.clear();
    --- End diff --
    
    I can add the 4 spaces for the above snippet 
    ```
    diff --git a/docs/dev/migration.md b/docs/dev/migration.md
    index c9a6ecfa1f..b7df4562ce 100644
    --- a/docs/dev/migration.md
    +++ b/docs/dev/migration.md
    @@ -148,7 +148,7 @@ public class BufferingSink implements 
SinkFunction<Tuple2<String, Integer>>,
                 // send it to the sink
             }
             bufferedElements.clear();
    -    }
    +        }
         }
     
         @Override
    ```


---

Reply via email to