Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r168773814
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -266,11 +305,16 @@ public RocksDBKeyedStateBackend(
RocksIterator iterator = db.newIterator(columnInfo.f0);
iterator.seekToFirst();
- Iterable<K> iterable = () -> new
RocksIteratorWrapper<>(iterator, state, keySerializer, keyGroupPrefixBytes);
+ Iterable<K> iterable = () -> new
RocksIteratorToJavaIteratorAdapter<>(iterator, state, keySerializer,
keyGroupPrefixBytes);
Stream<K> targetStream =
StreamSupport.stream(iterable.spliterator(), false);
--- End diff --
Fine with me, but since this seems to have not caused any trouble so far,
you might first want to check if the namespace parameter is actually required.
Maybe it can just be removed as parameter because the using code wants to
iterate all keys in all namespace.
---
