[
https://issues.apache.org/jira/browse/FLINK-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360616#comment-16360616
]
ASF GitHub Bot commented on FLINK-7713:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167520629
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarUploadHandler.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.webmonitor.handlers.ng;
+
+import org.apache.flink.api.common.time.Time;
+import org.apache.flink.runtime.rest.handler.AbstractRestHandler;
+import org.apache.flink.runtime.rest.handler.HandlerRequest;
+import org.apache.flink.runtime.rest.handler.RestHandlerException;
+import org.apache.flink.runtime.rest.messages.EmptyMessageParameters;
+import org.apache.flink.runtime.rest.messages.FileUpload;
+import org.apache.flink.runtime.rest.messages.MessageHeaders;
+import org.apache.flink.runtime.webmonitor.RestfulGateway;
+import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever;
+
+import
org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus;
+
+import javax.annotation.Nonnull;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Map;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionException;
+import java.util.concurrent.Executor;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Handles .jar file uploads.
+ */
+public class JarUploadHandler extends
+ AbstractRestHandler<RestfulGateway, FileUpload,
JarUploadResponseBody, EmptyMessageParameters> {
+
+ private final Path jarDir;
+
+ private final Executor executor;
+
+ public JarUploadHandler(
+ final CompletableFuture<String> localRestAddress,
+ final GatewayRetriever<? extends RestfulGateway>
leaderRetriever,
+ final Time timeout,
+ final Map<String, String> responseHeaders,
+ final MessageHeaders<FileUpload, JarUploadResponseBody,
EmptyMessageParameters> messageHeaders,
+ final Path jarDir,
+ final Executor executor) {
+ super(localRestAddress, leaderRetriever, timeout,
responseHeaders, messageHeaders);
+ this.jarDir = requireNonNull(jarDir);
+ this.executor = requireNonNull(executor);
+ }
+
+ @Override
+ protected CompletableFuture<JarUploadResponseBody> handleRequest(
+ @Nonnull final HandlerRequest<FileUpload,
EmptyMessageParameters> request,
+ @Nonnull final RestfulGateway gateway) throws
RestHandlerException {
+
+ final FileUpload fileUpload = request.getRequestBody();
+ return CompletableFuture.supplyAsync(() -> {
+ if
(!fileUpload.getPath().getFileName().toString().endsWith(".jar")) {
+ deleteUploadedFile(fileUpload);
+ throw new CompletionException(new
RestHandlerException(
+ "Only Jar files are allowed.",
+ HttpResponseStatus.BAD_REQUEST));
+ } else {
+ try {
+ Files.move(fileUpload.getPath(),
jarDir.resolve(fileUpload.getPath().getFileName()));
+ } catch (IOException e) {
--- End diff --
Should we try to delete the uploaded file in case of this error?
> Port JarUploadHandler to new REST endpoint
> ------------------------------------------
>
> Key: FLINK-7713
> URL: https://issues.apache.org/jira/browse/FLINK-7713
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, REST, Webfrontend
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Gary Yao
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Port {{JarUploadHandler}} to new REST endpoint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
