[GitHub] flink pull request #5442: [FLINK-7713][flip6] Implement JarUploadHandler

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5442#discussion_r167429671
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
 ---
    @@ -207,6 +215,53 @@ public static WebMonitor startWebRuntimeMonitor(
                }
        }
     
    +   @SuppressWarnings({"unchecked", "rawtypes"})
    +   public static <T extends RestfulGateway> 
List<Tuple2<RestHandlerSpecification, ChannelInboundHandler>> 
tryLoadJarUploadHandler(
    +                   GatewayRetriever<T> leaderRetriever,
    +                   CompletableFuture<String> restAddressFuture,
    +                   Time timeout,
    +                   java.nio.file.Path uploadDir,
    +                   Executor executor) {
    +
    +           // 1. Check if flink-runtime-web is in the classpath
    +           try {
    +                   final String classname = 
"org.apache.flink.runtime.webmonitor.WebRuntimeMonitor";
    --- End diff --
    
    Should be a constant.


---