[
https://issues.apache.org/jira/browse/FLINK-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352176#comment-16352176
]
ASF GitHub Bot commented on FLINK-8550:
---------------------------------------
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5404
Thanks for the PR @hequn8128!
Changes look good, +1 to merge
> Iterate over entryset instead of keys
> -------------------------------------
>
> Key: FLINK-8550
> URL: https://issues.apache.org/jira/browse/FLINK-8550
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
> Priority: Major
>
> Iterate over entrysets instead of keys when we want to get both key and
> value.
> For example, in \{{ProcTimeBoundedRangeOver}}:
> {code:java}
> // code placeholder
> val iter = rowMapState.keys.iterator
> val markToRemove = new ArrayList[Long]()
> while (iter.hasNext) {
> val elementKey = iter.next
> if (elementKey < limit) {
> ...
> val elementsRemove = rowMapState.get(elementKey)
> ...
> }
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
