Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5295
  
    I like the functionality of this a lot! However, I don't like that we 
change the signature of existing triggers or that we introduce new triggers 
that duplicate existing code.
    
    As an alternative, could you cast the `EventTimeTrigger` to `Trigger<T,W>` 
in `getDefaultTrigger()` of your new assigner?
    
    Also an additional idea, instead of putting the API method on 
`DynamicEventTimeSessionWindows` we could think about adding it to 
`EventTimeSessionWindows`. We would then have 
`EventTimeSessionWindows.withGap()` and 
`EventTimeSessionWindows.withGapExtractor()`. What do you think?


---

Reply via email to