[ 
https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346201#comment-16346201
 ] 

ASF GitHub Bot commented on FLINK-8357:
---------------------------------------

Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/5371
  
    I have changed the code, @StephanEwen @XuMingmin Welcome to review those 
codes ~ Thanks. I make the ```MaxFileSize``` to 200MB and storage for 30 days 
now.


> enable rolling in default log settings
> --------------------------------------
>
>                 Key: FLINK-8357
>                 URL: https://issues.apache.org/jira/browse/FLINK-8357
>             Project: Flink
>          Issue Type: Improvement
>          Components: Logging
>            Reporter: Xu Mingmin
>            Assignee: mingleizhang
>            Priority: Major
>             Fix For: 1.5.0
>
>
> The release packages uses {{org.apache.log4j.FileAppender}} for log4j and 
> {{ch.qos.logback.core.FileAppender}} for logback, which could results in very 
> large log files. 
> For most cases, if not all, we need to enable rotation in a production 
> cluster, and I suppose it's a good idea to make rotation as default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to