GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5351

    [FLINK-6623][Blob] BlobServer#putBuffer moves file after stream is cl…

    ## What is the purpose of the change
    
    In BlobServer#putBuffer we were moving a file while we still had an open 
FileOutputStream for it, causing the `BlobCacheSuccessTest` to categorically 
fail on Windows.
    
    The PR splits the existing try-with-resources block into 2 blocks: one for 
writing the data to the temporary file, and another one for moving the file to 
the storage directory.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 6623

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5351.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5351
    
----
commit 196efd73b5af16c4e7bc51ebe16cb886342c0d80
Author: zentol <chesnay@...>
Date:   2018-01-24T11:34:17Z

    [FLINK-6623][Blob] BlobServer#putBuffer moves file after stream is closed

----


---

Reply via email to