[GitHub] flink pull request #5307: [FLINK-8431] [mesos] Allow to specify # GPUs for T...

[EronWright]

Github user EronWright commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5307#discussion_r162464500
  
    --- Diff: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
 ---
    @@ -661,6 +661,7 @@ private LaunchableMesosWorker 
createLaunchableMesosWorker(Protos.TaskID taskID,
                // create the specific TM parameters from the resource profile 
and some defaults
                MesosTaskManagerParameters params = new 
MesosTaskManagerParameters(
                        resourceProfile.getCpuCores() < 1.0 ? 
taskManagerParameters.cpus() : resourceProfile.getCpuCores(),
    +                   taskManagerParameters.gpus(),
    --- End diff --
    
    We'll need to add GPU at some point to `ResourceProfile`.   @eastcirclek 
did you investigate that possibility?


---