[ 
https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327388#comment-16327388
 ] 

ASF GitHub Bot commented on FLINK-8275:
---------------------------------------

Github user EronWright commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5172#discussion_r161822100
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnTaskManagerRunner.java ---
    @@ -142,19 +134,22 @@ public static void runYarnTaskManager(String[] args, 
final Class<? extends YarnT
     
                        SecurityUtils.install(sc);
     
    -                   SecurityUtils.getInstalledContext().runSecured(new 
Callable<Object>() {
    -                           @Override
    -                           public Integer call() {
    -                                   try {
    -                                           
TaskManager.selectNetworkInterfaceAndRunTaskManager(configuration, resourceId, 
taskManager);
    -                                   }
    -                                   catch (Throwable t) {
    -                                           LOG.error("Error while starting 
the TaskManager", t);
    -                                           
System.exit(TaskManager.STARTUP_FAILURE_RETURN_CODE());
    +                   if (mainRunner == null) {
    --- End diff --
    
    If we need to separate out the 'secured' code block, can we do that in all 
scenarios instead of the conditional logic here?   For example, move the block 
on lines 138-147 to a new method, and pass a method reference to 
`runTaskManager` as the callable.  


> Flink YARN deployment with Kerberos enabled not working 
> --------------------------------------------------------
>
>                 Key: FLINK-8275
>                 URL: https://issues.apache.org/jira/browse/FLINK-8275
>             Project: Flink
>          Issue Type: Bug
>          Components: Security
>    Affects Versions: 1.4.0
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>            Priority: Blocker
>             Fix For: 1.5.0, 1.4.1
>
>
> The local keytab path in YarnTaskManagerRunner is incorrectly set to the 
> ApplicationMaster's local keytab path. This causes jobs to fail because the 
> TaskManager can't read the keytab.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to