[ 
https://issues.apache.org/jira/browse/FLINK-8368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325484#comment-16325484
 ] 

ASF GitHub Bot commented on FLINK-8368:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5270#discussion_r161374497
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/SubtaskExecutionAttemptDetailsHandler.java
 ---
    @@ -0,0 +1,131 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.handler.job;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.api.common.time.Time;
    +import org.apache.flink.runtime.execution.ExecutionState;
    +import org.apache.flink.runtime.executiongraph.AccessExecution;
    +import org.apache.flink.runtime.jobgraph.JobVertexID;
    +import org.apache.flink.runtime.rest.handler.HandlerRequest;
    +import org.apache.flink.runtime.rest.handler.RestHandlerException;
    +import org.apache.flink.runtime.rest.handler.legacy.ExecutionGraphCache;
    +import org.apache.flink.runtime.rest.handler.legacy.metrics.MetricFetcher;
    +import org.apache.flink.runtime.rest.handler.util.MutableIOMetrics;
    +import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
    +import org.apache.flink.runtime.rest.messages.JobIDPathParameter;
    +import org.apache.flink.runtime.rest.messages.JobVertexIdPathParameter;
    +import org.apache.flink.runtime.rest.messages.MessageHeaders;
    +import 
org.apache.flink.runtime.rest.messages.job.SubtaskAttemptMessageParameters;
    +import 
org.apache.flink.runtime.rest.messages.job.SubtaskExecutionAttemptDetailsInfo;
    +import org.apache.flink.runtime.rest.messages.job.metrics.IOMetricsInfo;
    +import org.apache.flink.runtime.taskmanager.TaskManagerLocation;
    +import org.apache.flink.runtime.webmonitor.RestfulGateway;
    +import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever;
    +import org.apache.flink.util.Preconditions;
    +
    +import java.util.Map;
    +import java.util.concurrent.CompletableFuture;
    +import java.util.concurrent.Executor;
    +
    +/**
    + * Handler of specific sub task execution attempt.
    + */
    +public class SubtaskExecutionAttemptDetailsHandler extends 
AbstractSubtaskAttemptHandler<SubtaskExecutionAttemptDetailsInfo, 
SubtaskAttemptMessageParameters> {
    +
    +   private final MetricFetcher<?> metricFetcher;
    +
    +   /**
    +    * Instantiates a new Abstract job vertex handler.
    --- End diff --
    
    wrong java docs: Should be `SubtaskExecutionAttemptDetailsHandler`.


> Port SubtaskExecutionAttemptDetailsHandler to new REST endpoint
> ---------------------------------------------------------------
>
>                 Key: FLINK-8368
>                 URL: https://issues.apache.org/jira/browse/FLINK-8368
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST
>            Reporter: Biao Liu
>            Assignee: Biao Liu
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> Migrate 
> org.apache.flink.runtime.rest.handler.legacy.SubtaskExecutionAttemptDetailsHandler
>  to new a REST handler that registered in WebMonitorEndpoint.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to